Browse Source

Added some TODOs

pull/46/head
Anairkoen Schno 5 years ago
parent
commit
d76bc8f44c
4 changed files with 5 additions and 13 deletions
  1. +1
    -1
      IPA.Loader/Config/Stores/GeneratedStore.cs
  2. +1
    -1
      IPA.Loader/Loader/PluginManager.cs
  3. +0
    -10
      IPA.Loader/PluginInterfaces/BeatSaber/IDisablablePlugin.cs
  4. +3
    -1
      IPA.Loader/PluginInterfaces/BeatSaber/IPlugin.cs

+ 1
- 1
IPA.Loader/Config/Stores/GeneratedStore.cs View File

@ -288,7 +288,7 @@ namespace IPA.Config.Stores
var nonNullables = attrs.Select(o => o as NonNullableAttribute).NonNull(); var nonNullables = attrs.Select(o => o as NonNullableAttribute).NonNull();
name = member.Name; name = member.Name;
isNullable = memberType.IsConstructedGenericType
isNullable = memberType.IsConstructedGenericType // TODO: figure out something to support this in .NET 3
&& memberType.GetGenericTypeDefinition() == typeof(Nullable<>); && memberType.GetGenericTypeDefinition() == typeof(Nullable<>);
allowNull = !nonNullables.Any() && (!memberType.IsValueType || isNullable); allowNull = !nonNullables.Any() && (!memberType.IsValueType || isNullable);


+ 1
- 1
IPA.Loader/Loader/PluginManager.cs View File

@ -153,7 +153,7 @@ namespace IPA.Loader
/// <param name="plugin">the plugin to enable</param> /// <param name="plugin">the plugin to enable</param>
/// <returns>whether a restart is needed to activate</returns> /// <returns>whether a restart is needed to activate</returns>
public static bool EnablePlugin(PluginMetadata plugin) public static bool EnablePlugin(PluginMetadata plugin)
{
{ // TODO: fix some of this behaviour, by adding better support for runtime enable/disable of mods
if (plugin == null) return false; if (plugin == null) return false;
if (plugin.IsBare) if (plugin.IsBare)


+ 0
- 10
IPA.Loader/PluginInterfaces/BeatSaber/IDisablablePlugin.cs View File

@ -5,16 +5,6 @@
/// </summary> /// </summary>
public interface IDisablablePlugin public interface IDisablablePlugin
{ {
/*/// <summary>
/// Called when a plugin is enabled. This is where you should set up Harmony patches and the like.
/// </summary>
/// <remarks>
/// This will be called after Init, and will be called when the plugin loads normally too.
/// When a plugin is disabled at startup, neither this nor Init will be called until it is enabled.
///
/// Init will only ever be called once.
/// </remarks>
void OnEnable();*/
/// <summary> /// <summary>
/// Called when a plugin is disabled at runtime. This should disable things like Harmony patches and unsubscribe /// Called when a plugin is disabled at runtime. This should disable things like Harmony patches and unsubscribe


+ 3
- 1
IPA.Loader/PluginInterfaces/BeatSaber/IPlugin.cs View File

@ -16,7 +16,7 @@ namespace IPA
/// Called when a plugin is enabled. This is where you should set up Harmony patches and the like. /// Called when a plugin is enabled. This is where you should set up Harmony patches and the like.
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// This will be called after Init, and will be called when the plugin loads normally too.
/// This will be called after <c>Init</c>, and will be called when the plugin loads normally too.
/// When a plugin is disabled at startup, neither this nor Init will be called until it is enabled. /// When a plugin is disabled at startup, neither this nor Init will be called until it is enabled.
/// ///
/// Init will only ever be called once. /// Init will only ever be called once.
@ -28,6 +28,8 @@ namespace IPA
/// </summary> /// </summary>
void OnApplicationQuit(); void OnApplicationQuit();
// TODO: move more of these out of IPlugin
/// <summary> /// <summary>
/// Gets invoked on every graphic update. /// Gets invoked on every graphic update.
/// </summary> /// </summary>


Loading…
Cancel
Save