From dd00c7442be0734e2763234b6401afc28fac63ae Mon Sep 17 00:00:00 2001 From: DaNike Date: Sat, 20 May 2023 19:24:41 -0500 Subject: [PATCH] Formatting --- IPA.Loader/Config/Stores/GeneratedStoreImpl/Correction.cs | 1 + .../Config/Stores/GeneratedStoreImpl/Deserialization.cs | 1 + IPA.Loader/Loader/PluginManager.cs | 6 ++++-- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/IPA.Loader/Config/Stores/GeneratedStoreImpl/Correction.cs b/IPA.Loader/Config/Stores/GeneratedStoreImpl/Correction.cs index b59bf7d0..2d69d585 100644 --- a/IPA.Loader/Config/Stores/GeneratedStoreImpl/Correction.cs +++ b/IPA.Loader/Config/Stores/GeneratedStoreImpl/Correction.cs @@ -46,6 +46,7 @@ namespace IPA.Config.Stores var endLabel = il.DefineLabel(); + // TODO: when we have a nullable, we need to save to a local to call methods if (member.IsNullable) { il.Emit(OpCodes.Dup); diff --git a/IPA.Loader/Config/Stores/GeneratedStoreImpl/Deserialization.cs b/IPA.Loader/Config/Stores/GeneratedStoreImpl/Deserialization.cs index 7f8e44f6..07904fce 100644 --- a/IPA.Loader/Config/Stores/GeneratedStoreImpl/Deserialization.cs +++ b/IPA.Loader/Config/Stores/GeneratedStoreImpl/Deserialization.cs @@ -112,6 +112,7 @@ namespace IPA.Config.Stores { il.Emit(OpCodes.Stloc, mapLocal); + // TODO: handle creating a nullable, when applicable EmitLoad(il, member, thisarg); il.Emit(OpCodes.Stloc, resultLocal); diff --git a/IPA.Loader/Loader/PluginManager.cs b/IPA.Loader/Loader/PluginManager.cs index b323366f..a54fbcb6 100644 --- a/IPA.Loader/Loader/PluginManager.cs +++ b/IPA.Loader/Loader/PluginManager.cs @@ -199,7 +199,8 @@ namespace IPA.Loader var res = TaskEx.WhenAll(exec.Dependents.Select(d => Disable(d, alreadyDisabled))) .ContinueWith(t => { - if (t.IsFaulted) { + if (t.IsFaulted) + { return TaskEx.WhenAll(t, TaskEx6.FromException( new CannotRuntimeDisableException(exec.Executor.Metadata, "Dependents cannot be disabled for plugin"))); } @@ -208,7 +209,8 @@ namespace IPA.Loader { foreach (var feature in exec.Executor.Metadata.Features) { - try { + try + { feature.AfterDisable(exec.Executor.Metadata); } catch (Exception e)